Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSDV-5340: Storage links creation for Remove duplicates #4439

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

makseq
Copy link
Member

@makseq makseq commented Jun 23, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for label-studio-docs-new-theme failed.

Name Link
🔨 Latest commit 5376dd7
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/649618340a6ef700084f3d9c

@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for heartex-docs failed.

Name Link
🔨 Latest commit 5376dd7
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64961834e59fc60008427e52

@github-actions github-actions bot added the fix label Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (e93075d) 75.49% compared to head (5376dd7) 75.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4439      +/-   ##
===========================================
+ Coverage    75.49%   75.57%   +0.07%     
===========================================
  Files          156      156              
  Lines        12189    12216      +27     
===========================================
+ Hits          9202     9232      +30     
+ Misses        2987     2984       -3     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@makseq makseq merged commit 35618d5 into develop Jun 23, 2023
27 of 35 checks passed
@makseq makseq deleted the fb-LSDV-5340 branch June 23, 2023 22:39
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
…gnal#4439)

* fix: LSDV-5340: Storage links creation for Remove duplicates

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant