Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A newly appended block header should not build on an invalid chain #384

Open
yixiao5428 opened this issue Jul 17, 2021 · 0 comments
Open

A newly appended block header should not build on an invalid chain #384

yixiao5428 opened this issue Jul 17, 2021 · 0 comments

Comments

@yixiao5428
Copy link

This is a security vulnerability.

Currently, a new header descendant from an invalid block is still accepted.

A possible solution is to get the ancestor of the block, check the validity of the block indexes, and return error is failed, in the AcceptBlockHeader() function of src/main.cpp after line 3714.

Similar fix from Bitcoin: bitcoin/bitcoin@015a525.

Reported by 6004ed5feaa31ae9df36b5dbc60f0fa53255a5fb734334082c6d202405fc738c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yixiao5428