Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insufficient test coverage of RPC command outputs #173

Open
cronicc opened this issue Jun 18, 2019 · 0 comments
Open

Insufficient test coverage of RPC command outputs #173

cronicc opened this issue Jun 18, 2019 · 0 comments
Labels
Enhancement New feature or request

Comments

@cronicc
Copy link
Member

cronicc commented Jun 18, 2019

RPC command output is not sufficiently checked by our current RPC tests, otherwise we'd have detected #172 earlier.

A RPC test should be added validating each RPC command against expected outputs.
@cronicc cronicc added the Enhancement New feature or request label Jun 18, 2019
@cronicc cronicc mentioned this issue Dec 12, 2019
Merged
cronicc pushed a commit that referenced this issue Nov 12, 2021
@albertog78
Merge pull request #173 from HorizenOfficial/getblocktemplate_certifi…
9ca6f98 
…cates_fix

Fix for certificates handling in GetBlockTemplate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cronicc