Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab key to toolbar #1001

Open
deveee opened this issue Jul 24, 2024 · 7 comments
Open

Add tab key to toolbar #1001

deveee opened this issue Jul 24, 2024 · 7 comments
Labels
contributor needed There will not be any progress without someone volunteering to work on this enhancement New feature or request

Comments

@deveee
Copy link

deveee commented Jul 24, 2024

There are already up/down/left/right arrows. It would be useful to also add tab key, so it can be used to autocomplete commands in terminal or just switch between input fields.

I can add it in custom layout but toolbar would be better because there is free space there and it's less probable that I would accidentally touch it during typing text.

Actually I miss also "ctrl" button to be 100% happy.

Or maybe add "full keyboard" layout in landscape mode like in hacker's keyboard.

@deveee deveee added the enhancement New feature or request label Jul 24, 2024
@deveee
Copy link
Author

deveee commented Jul 24, 2024

The tab key seems simple enough
deveee@b924e3b

Not sure if you are interested in it.

Note that I had to reset toolbar layout to make it visible in settings.

@devycarol
Copy link
Contributor

I'd hate to see that toolbar config get too daunting (I say this as the person whose made a fifth of those keys and counting...)

I think this is a good idea, and converting existing keys to toolbar ones is trivial. I just wonder if there'll be a way to maintain/improve the approachability of the toolbar config as these keys pile up. Visible categories (navigation, editing, etc.) and improved drag-drop behavior are both ideas that come to mind.

@Helium314
Copy link
Owner

I'm against adding normal keys to the toolbar list, as @devycarol mentioned there is already a large number of keys. And adding even more keys will make people want a completely re-worked screen to adjust toolbar keys, simply because there are too many keys for the current style (it's already too much imo).

Only thing I'd be ok with is (if it's reasonably simple!) is adding some sort of customitzable toolbar keys that allow you to define the key code.

@Helium314 Helium314 added the contributor needed There will not be any progress without someone volunteering to work on this label Jul 25, 2024
@devycarol
Copy link
Contributor

Oh yeah I 100% agree with "custom" key approach.

@Helium314
Copy link
Owner

When only allowing a certain number of configurable keys, it should be reasonably simple to add such toolbar keys (just check key code in settings).
The icon is an issue though. Here it would be helpful to first do the planned changes to KeyboardIconsSet (for decoupling from theme style, not sure where it was discussed).

@devycarol
Copy link
Contributor

#980 methinks.

@Helium314
Copy link
Owner

That's it, thanks!
I'll work on step 1 when I have some time (not before next week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor needed There will not be any progress without someone volunteering to work on this enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants