Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fido Scraper Client #75

Open
nabobalis opened this issue Sep 6, 2022 · 5 comments
Open

Fido Scraper Client #75

nabobalis opened this issue Sep 6, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nabobalis
Copy link
Collaborator

nabobalis commented Sep 6, 2022

We can create a Fido (https://docs.sunpy.org/en/stable/generated/api/sunpy.net.Fido.html?highlight=fido) client that would let people search and fetch the full images that are stored in JPEG2000 or PNG formats.

Implementing the Client

The client would use the URL scraper to find files on the remote server.
The three components that are needed to make the client are:

  • Attribute Base URL: https://api.helioviewer.org/jp2/
  • Attribute Pattern: This is a template that is used to extract the metadata from urls matched by base url.

For example, https://api.helioviewer.org/jp2/AIA/335/2012/01/29/ this URL can be used to make a request, breaking it down we have this template:

Untitled

  • Define the method register_value() which registers attributes supported by the client.
    The attrs returned by this method are used to match the client search attrs.
@nabobalis nabobalis changed the title Fido Scarper Client Fido Scraper Client Sep 6, 2022
@nabobalis nabobalis added enhancement New feature or request help wanted Extra attention is needed labels Oct 17, 2022
@exitflynn
Copy link

hey @nabobalis! do we still want this? I would love to contribute!

@nabobalis
Copy link
Collaborator Author

I think so but I want @dgarciabriseno to chime in here.

If the plan is to create an API that does this, then in theory we won't need this client as it stands.
Instead of a Fido scrapper client, it would become an Fido API client.

@dgarciabriseno
Copy link
Collaborator

@nabobalis @exitflynn This topic just came up. I do plan to implement an API for querying and downloading images.

@nabobalis
Copy link
Collaborator Author

@nabobalis @exitflynn This topic just came up. I do plan to implement an API for querying and downloading images.

In that case, I think this issue should hold until that API exists, or would you want this client to be created before that?

@dgarciabriseno
Copy link
Collaborator

We can make the FIDO scraper client, I expect it would be easier to implement since the base classes for implementing it are already in place.

I am working on a search API. It'll offer a bit more than just pointing to images to download. We have some use cases for being able to search images by more than just date and time and also for returning some FITS header data instead of just pointing directly to the images.

So I'm thinking we can have both since they will serve different use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants