Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Rewrite: Remove CodeClimate code & stuff #11

Open
vovimayhem opened this issue Mar 13, 2017 · 0 comments
Open

App Rewrite: Remove CodeClimate code & stuff #11

vovimayhem opened this issue Mar 13, 2017 · 0 comments

Comments

@vovimayhem
Copy link
Member

vovimayhem commented Mar 13, 2017

This project was created in a hurry. I ended copying some of the code climate code into this one, then changing stuff.

While implementing #9, I noticed most of the abstractions on CodeClimate are a bit clunky - at least for this project's goals. Also, the fact that CodeClimate can do with streaming the engine output directly to STDOUT, whereas Belugas can't do that (subsequent engines may depend on the previous engine output) makes other CodeClimate abstractions get in the way for our use case.

Maybe we can do much of the container management stuff using github.com/xeger/docker gem, remove the codeclimate gem & code, and have a much simpler codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant