Fix flaky test in SearchesCleanUpJobWithDBServicesTest #20740
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I encountered non-deterministic behavior for test:
org.graylog.plugins.views.search.db.SearchesCleanUpJobWithDBServicesTest#testMixedExpiredNonExpiredReferencedAndNonReferencedSearches
Error Message:
Motivation and Context
The test was previously using
containsExactly
, which assumes a strict order for the captured values. However, captured value inherently relies on unordered collectionHashSet
at SearchesCleanUpJob.java#L99 which inherently calls SearchDbService.java#L145.For this test, to avoid flakiness, I think we can switch to
containsExactlyInAnyOrder
by checking for the presence of all elements, regardless of their order.How Has This Been Tested?
I found this non-deterministic behavior by running NonDex.
NonDex:https://github.com/TestingResearchIllinois/NonDex
In short, NonDex is a tool that introduces randomness by deliberately shuffling e.g. unordered collections like HashSet to detect flakiness in code.
You can reproduce the failures/run the tests with NonDex by using the command e.g.:
Types of changes
Checklist: