Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WhoisIpLookup over-reporting errors #20571

Open
waab76 opened this issue Sep 26, 2024 · 0 comments
Open

WhoisIpLookup over-reporting errors #20571

waab76 opened this issue Sep 26, 2024 · 0 comments

Comments

@waab76
Copy link
Contributor

waab76 commented Sep 26, 2024

Expected Behavior

The WHOIS data adapter should only report 1 error per lookup attempt.

Current Behavior

WHOIS lookups can be redirected many times which the data adapter handles with recursive calls to its run() method. When a lookup attempts results in an IOException (generally due to a timeout), that exception is logged and re-thrown. This means that the exception will be logged for each WHOIS server in the chain of redirects as it works its way back up the call stack.

Possible Solution

Do not re-throw IOExceptions here:

} catch (IOException e) {
LOG.error("Could not lookup WHOIS information for [{}] at [{}].", ip, registry.toString());
throw e;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants