Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork CFFI #26

Open
eschulte opened this issue Sep 3, 2022 · 4 comments
Open

Fork CFFI #26

eschulte opened this issue Sep 3, 2022 · 4 comments

Comments

@eschulte
Copy link
Contributor

eschulte commented Sep 3, 2022

To load CFFI (and thus SEL) on a Mac M1 the latest changes from the main CFFI branch are required. Unfortunately death doesn't want to merge those into their fork of CFFI used by SEL. They suggest (see death/cffi#2 (comment)) maintaining a fork of CFFI with these changes and any others needed by SEL. You're welcome to use the fork I've started for this purpose (https://github.com/eschulte/cffi) or maybe you'd rather host one under GrammaTech on GitHub.

@berchn
Copy link
Contributor

berchn commented Sep 6, 2022

I'm of the opinion that it would be better to modify cl-tree-sitter to not need the CFFI fork than to maintain our own.

@pfdietz
Copy link
Contributor

pfdietz commented Sep 6, 2022

If we're going to monkey with cffi, can we look into efficiency? I'm seeing as much as 75% of the time during a parse being spent in cffi interface code.

@eschulte
Copy link
Contributor Author

If it's possible and reasonably easy to modify cl-tree-sitter so it can use the upstream cffi then I agree that definitely sounds preferable. I haven't looked at any of the cl-tree-sitter CFFI calls and don't know anything of the content of the CFFI fork used by cl-tree-sitter. I suspect death would be supportive as they don't seem excited about maintaining CFFI forks.

@berchn
Copy link
Contributor

berchn commented Feb 15, 2023

death/cl-tree-sitter#8
We've made some changes to make cl-tree-sitter work with stock CFFI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants