Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oss-prow alert is very flaky on GitHub token usage #1173

Open
chaodaiG opened this issue Oct 6, 2021 · 2 comments
Open

oss-prow alert is very flaky on GitHub token usage #1173

chaodaiG opened this issue Oct 6, 2021 · 2 comments

Comments

@chaodaiG
Copy link
Member

chaodaiG commented Oct 6, 2021

Current alert is off when the predicted token consumption is over the rate limit before next token reset, this could happen when there is a sharp drop early after token reset, which doesn't necessarily mean the slope would continue like this. This had happened quite frequently in the past few weeks and it's very noise.

An idea fixing this would be to add another condition like trigger only when the token consumption is above 80%

@chases2
Copy link
Collaborator

chases2 commented May 13, 2022

Hook, Tide, and Crier seem to be using an anonymous GitHub client. That seems like it would make this issue worse:

component: "tide"
file: "k8s.io/test-infra/prow/flagutil/github.go:260"
func: "k8s.io/test-infra/prow/flagutil.(*GitHubOptions).githubClient"
level: "warning"
msg: "empty -github-token-path, will use anonymous github client"
}

@chaodaiG
Copy link
Member Author

Hook, Tide, and Crier seem to be using an anonymous GitHub client. That seems like it would make this issue worse:

This warning is false alert, these components use GH app for authenticating, I'm fixing this false warning in kubernetes/test-infra#26322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants