Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always collect metrics for the root ns and optionally collect metrics for the pod namespaces #115

Open
MrHohn opened this issue Aug 27, 2021 · 0 comments

Comments

@MrHohn
Copy link
Collaborator

MrHohn commented Aug 27, 2021

Basically the way we collect netlink metrics makes it necessary to turn on hostPID, which we are not ready to do yet.

See #113 (comment) for the context - adding an issue so that we don't lose track.

I think we can do two things - always collect metrics for the root ns (and label it by the node IP I guess) and optionally if the pod watch is enabled, also collect metrics for the pod namespaces.

I think this will require some additional work to figure out how to export the root ns metrics into a K8sContainer schema. So for now, I think just create an issue so we don't lose track and we can merge this PR.

cc @varunmar @michaelasp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant