Incompatibility with MoreCulling

[VoidWalkerAsh-1]

What's the issue you encountered?

All I did was have a working modpack and added serene seasons to it with glitchcore as the main dependency, I'm on 1.20.4 with everything up to date, fabric 0.15.6 and the game just crashes when it gets to the mojang screen

How can the issue be reproduced?

I really dont know, all I know is when I add the mod it crashes but other mods like Biomes O' Plenty don't

Logs

https://gist.github.com/AshTheNerd/141917a18ccefffa4a03706f0047d79e

Mod Version

SereneSeasons-fabric-1.20.4-9.3.9.18

Additional information

No response

[VoidWalkerAsh-1]

and yes I tried older versions of the 1.20.4 one and the same crash occurs

[Adubbz]

This is most likely a conflict with the mixins from another mod, though from your log it's not clear which one. You'll need to remove mods to figure out which one.

[VoidWalkerAsh-1]

alright

[VoidWalkerAsh-1]

This is most likely a conflict with the mixins from another mod, though from your log it's not clear which one. You'll need to remove mods to figure out which one.

Its now the only one on in the modpack and its still happening besides cloth config even with cloth config off it still happened

https://gist.github.com/AshTheNerd/2bf174e29531e8945e732aa77f88f5ce

[Adubbz]

Your log says you still have e.g Iris, Sodium, Wilder Wild and mod menu installed. It is definitely not the only mod

[VoidWalkerAsh-1]

Your log says you still have e.g Iris, Sodium, Wilder Wild and mod menu installed. It is definitely not the only mod

they weren't showing in curse forge, gotta go into the files then and remove them manually

[VoidWalkerAsh-1]

Your log says you still have e.g Iris, Sodium, Wilder Wild and mod menu installed. It is definitely not the only mod

I found the problem. it was apparently the performance mod moreculling-1.20.4-0.22.1

that's all the mod does so that's weird.

[Adubbz]

We have a mixin to disable raining based on the season here https://github.com/Glitchfiend/SereneSeasons/blob/1.20.4-multi/common/src/main/java/sereneseasons/mixin/client/MixinLevelRenderer.java#L54. It seems they inject into the exact same place as we do as per https://github.com/FxMorin/MoreCulling/blob/master/src/main/java/ca/fxco/moreculling/mixin/WorldRenderer_rainMixin.java#L60. I'd probably suggest opening an issue on their side as well.

[VoidWalkerAsh-1]

Aight got it, thanks for the help!

[FxMorin]

We could fix this by both changing our redirects to WrapOperation's.
Ill try to find some time to so it.

[vico93]

Just FYI, FxMorin fixed (no partial pun intended) his side of the issue via FxMorin/MoreCulling@eebfcb3.

[vico93]

Any updates about this? The issue was fixed by @FxMorin on MoreCulling's side, but needs to be fixed also in SereneSeasons' side.

[VoidWalkerAsh-1]

I haven't been active with mc modding for a littlw while now because I've been busy with stuff so not really anything

…

On Thu, May 16, 2024, 9:01 AM Vico ***@***.***> wrote: Any updates about this? The issue was fixed by @FxMorin <https://github.com/FxMorin> on MoreCulling's side, but needs to be fixed also in SereneSeasons' side. — Reply to this email directly, view it on GitHub <#452 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYQA6QLZSDGFTG6BVXHO3WTZCSU4BAVCNFSM6AAAAABCXYBVYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGE4TAMBZGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[MUKSC]

Serene Seasons doesn't have to do anything. It's already fixed in MoreCulling v0.25.0, and current version of Serene Seasons will work just fine with that.
However MoreCulling v0.25.0 is only available in 1.20.[5-6].
@vico93 I'm asssuming you're playing on 1.20.[1-4], so you may want to open a issue for backport in MoreCulling's side.

[vico93]

Serene Seasons doesn't have to do anything. It's already fixed in MoreCulling v0.25.0, and current version of Serene Seasons will work just fine with that. However MoreCulling v0.25.0 is only available in 1.20.[5-6]. @vico93 I'm asssuming you're playing on 1.20.[1-4], so you may want to open a issue for backport in MoreCulling's side.

I was basically saying what @FxMorin put in the commit:

- Fixes crash with Serene Seasons (once they also use WrapOperation)

btw i dont have deep knowledge about how those things work, i only listen the modders 🤷🏻

[MUKSC]

No worries, I was just letting you know that you can already play with both mods in 1.20.[5-6]. If you want to play on older versions, request a backport of MoreCulling v0.25.0 on their side👍

I think this issue can be closed.

[MCRusher]

So just in case someone else runs into this, I made a modified 24.0 version of More Culling with the changes to the mixin they added to 25.0 so I could run them together on 1.20.4.

If it doesn't work then, sorry. But it works for me.

https://drive.google.com/file/d/1ixFVULTuAigHeYDkGal4dW86iXCnhwn1/view?usp=sharing