Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented code splitting #260

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Implemented code splitting #260

wants to merge 1 commit into from

Conversation

akshay1027
Copy link

Description

Implemented code splitting to increases performance

Fixed #257

Please check options that are relevant to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have pulled the latest changes in the repository
  • I have squashed my commits
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@akshay1027
Copy link
Author

akshay1027 commented May 21, 2021 •
edited
Loading

before code Splitting

2021-05-21 (1)

aftercode Splitting

2021-05-21 (4)

@akshay1027
Copy link
Author

@vaishali614 check this out and let me know

vaishali614
vaishali614 requested changes May 21, 2021
View reviewed changes
Copy link
Member

@vaishali614 vaishali614 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshay1027 Looks good. Few changes required:

  1. Delete the commented and unwanted code
  2. View opportunity pages don't work. Please check that.
  3. Instead of 'Loading...', use some spinner from here. I like the Grow Spinner. Also, try giving it some margin along y-axis so that the footer is in the bottom and spinner is in the middle of the page.

@akshay1027
Copy link
Author

Yea if your okay with these, I was planning to make another issue for spinner!!

@vaishali614
Copy link
Member

Yea if your okay with these, I was planning to make another issue for spinner!!

Okay, but please make sure that other two changes are done in this PR.

@vaishali614
Copy link
Member

vaishali614 commented May 24, 2021 •
edited
Loading

@akshay1027 Any updates?
Also, please make sure you update your PR after resolving the merge conflicts.

@vaishali614
Copy link
Member

@akshay1027 Are you still working on this PR or should I close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaishali614 vaishali614 vaishali614 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement route based code splitting and lazy loading
2 participants
@akshay1027 @vaishali614