Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI Crash if project uses CMake version 3.22.1 #188

Open
perracodex opened this issue Aug 1, 2022 · 3 comments
Open

JNI Crash if project uses CMake version 3.22.1 #188

perracodex opened this issue Aug 1, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@perracodex
Copy link

🐛 Bug Report

For projects with NDK code that use the latest CMake version 3.22.1, Giphy's search dialog crashes after a couple of seconds once opened.
Giphy's dialog opens and shows empty-colored placeholders, but no actual media is displayed on them, then crashes after a couple seconds.

The stacktrace (see attachment) seems to point to a JNI issue in fresco's library.

No issues with the previous CMake version 3.18.1, reverting to it makes the problem disappear.

Note that the usage of NDK and CMake in the project is completely unrelated to Giphy. The NDK is used exclusively for unrelated specific project features.
The crash happens only when using the latest CMake version 3.22.1.
Cleaning, rebuilding, etc., doesn't solve the issue. Only reverting to a previous CMake solves it.

Your Environment

  • Giphy Android SDK version: 2.1.18, but also tested in 2.1.17
  • Device info (Emulator/Device? Android version? Debug/Release?): Xioami Redmi Note 10 Pro, Android 12 (API 31)

Stacktrace

Stacktrace.txt

@perracodex perracodex added the bug Something isn't working label Aug 1, 2022
@ALexanderLonsky
Copy link
Collaborator

Hey @perracolabs, thanks for reporting this and comprehensive description of the problem.
Though I don't know what I can do about it now; so, I'll keep it open until further notice.

P.S. I see that the latest CMake version is 3.23.3, is it possible to try that version?

@perracodex
Copy link
Author

The newest CMake version that Android Studio gives me is 3.22.1.
I update it via the SDK Manager \ SDK tools tab.
3.23.3 doesn't appear in my list of supported versions.
I'm using Android Studio Chipmunk 2021.2.1 Patch 1.

Maybe the only solution is to make Facebook aware of the issue with Fresco. I assume Giphy already uses the latest Fresco version.

@ALexanderLonsky
Copy link
Collaborator

I see. Yes, we are using the latest version: 2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants