Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to activate trailing delimiter for CSV parser #4174

Open
stefan-korn opened this issue May 2, 2024 · 1 comment · May be fixed by #4175
Open

Allow to activate trailing delimiter for CSV parser #4174

stefan-korn opened this issue May 2, 2024 · 1 comment · May be fixed by #4175

Comments

@stefan-korn
Copy link
Contributor

stefan-korn commented May 2, 2024

User Story

The csv paser library allows for a "traling delimiter" to be activated.

Currently it is not possible to activate this through the DKAN implementation.

Currently the parser configuration can be changed via ImportService::EVENT_CONFIGURE_PARSER, see #3864 .

It would be nice to be able to activate the trailing delimiter through this mechanism too.

Proposing to introduce a parser configuration setting for this. Setting this to FALSE by default , will not change the current behavior, but allow for changing via Event Subscriber if desired.

Acceptance Criteria

Trailing delimiter can be changed via ImportService::EVENT_CONFIGURE_PARSER.

@stefan-korn stefan-korn linked a pull request May 2, 2024 that will close this issue
4 tasks
@dafeder
Copy link
Member

dafeder commented May 2, 2024

Sounds good. See PR comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants