Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Villager and Enchanted Book Support #51

Open
MysteryTimeTrav opened this issue Apr 12, 2021 · 6 comments
Open

Allow for Villager and Enchanted Book Support #51

MysteryTimeTrav opened this issue Apr 12, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@MysteryTimeTrav
Copy link

Hi, this is an enhancement request.

Is it possible to allow for these enchantments to be obtained via an enchanted books and by extension have them be sold by villagers?

@Geolykt Geolykt added the enhancement New feature or request label Apr 12, 2021
@Geolykt
Copy link
Owner

Geolykt commented Apr 12, 2021

The enchantments are already obtainable via enchanted books, however villager selling them has not yet been implemented.
I might add that one day, but given that I have never poked a villager trades, this may as well never happen (just like Trident support [though for it I'm waiting on feedback from a fork]).

@jaspqrr
Copy link

jaspqrr commented Aug 26, 2022

did you ever add this? and if not how do you obtain enchantments in survival and are the enchantments usable on players?

@Geolykt
Copy link
Owner

Geolykt commented Aug 26, 2022

Enchantments are available through the enchantment table. However villagers still do not sell these enchantments

@jaspqrr
Copy link

jaspqrr commented Aug 27, 2022

oh okay thank you and are you still considering to add it through villagers?

@Geolykt
Copy link
Owner

Geolykt commented Aug 27, 2022

It is planned to do it eventually, but no efforts are underway as of now. That is if someone makes a PR it is likely to get accepted - if noone does it it might take an unknown amount of time until that gets implemented. I myself as a player don't really find it annoying that villagers don't sell the books so therefore I don't really have a motivation to add it and always delay it to "later"

@jaspqrr
Copy link

jaspqrr commented Aug 27, 2022

Okay thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants