Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shield Durability with Ethereal #124

Open
CrimsonSerpent5 opened this issue Apr 19, 2022 · 5 comments
Open

Shield Durability with Ethereal #124

CrimsonSerpent5 opened this issue Apr 19, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@CrimsonSerpent5
Copy link

Putting Ethereal on a Shield does not make the durability go away.

@Geolykt
Copy link
Owner

Geolykt commented Apr 19, 2022

What is your patches.yml? And does /ench list take note of your enchantment? Chances are this is working as intended

@CrimsonSerpent5
Copy link
Author

CrimsonSerpent5 commented Apr 20, 2022 via email

@Geolykt
Copy link
Owner

Geolykt commented Apr 20, 2022

Well you see by default none of the plugins enchantments can work on shields. I'd have to check whether changing that causes any issue with other enchantments though

@Geolykt Geolykt added the enhancement New feature or request label Apr 20, 2022
@CrimsonSerpent5
Copy link
Author

Has this been fixed yet?

@Geolykt
Copy link
Owner

Geolykt commented May 6, 2022

Everything that wasn't closed wasn't resolved yet. I am particularly slow at feature requests due to low motivation.
That being said you can add shields to https://github.com/Geolykt/EnchantmentsPlus/blob/4xx/resources/magicCompat.yml#L285 and https://github.com/Geolykt/EnchantmentsPlus/blob/4xx/resources/patches.yml#L34 and it should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants