Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Testing meca -I to place symbols in a legend or box #4449

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

PaulWessel
Copy link
Member

Description of proposed changes

See #4445. This PR tests this concept. For example you can try this command and change the -I choices:

echo -159.70 54.81 39 0.82 -0.68 -0.14 0.63 0.34 -0.40 25 | gmt meca -R0/10/0/5 -Jx1c -B0 -Sm2.5c -M -G110/168/255 -T0 -W0.5p -IjTR+o0.25c -png map

map

Few things to know:

  1. Regardless of input file, only the first record is plotted - we then skip the rest
  2. The symbol size is what -S gives - no scaling by magnitude
  3. The -N is turned on since -IJ will place things outside rather than inside the box
  4. While -Ix should not need -R -J I have not implemented that yet since affects THIS_MODULE_NEEDS
  5. The -C option should be disallowed or ignored when -I is used.

We should make a test page of all the 9 meca symbols using the 9 adjustment points.

@PaulWessel PaulWessel added the new feature PR that implements a new feature or capability in GMT label Nov 12, 2020
@PaulWessel PaulWessel self-assigned this Nov 12, 2020
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Jun 12, 2021
@PaulWessel
Copy link
Member Author

Hi @seisman, I think you voted this down when I put this together. If that is still the sentiment then I can delete this branch, yes?

@seisman
Copy link
Member

seisman commented Jun 7, 2022

If I understand it correctly, after implementing the new legend code proposed in #4445 (comment), the -I option implemented in this PR is no longer needed. If anyone wants to place a beachball at the top-right corner, he can always pass the new legend code to legend.

@PaulWessel
Copy link
Member Author

Ah yes, I hate these abandoned issues of mine... Thanks for reminding me. Yes this is the better solution but not implemented yet. I think I will wait with deleting the branch in case I may reuse some of the coding there for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog new feature PR that implements a new feature or capability in GMT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants