Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharo class RsrConnectionClosedBeforeReceivingResponse should be a subclass of Error #147

Open
ericwinger opened this issue Mar 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ericwinger
Copy link
Member

A RsrPromise block catch: block can get a RsrConnectionClosedBeforeReceivingResponse. However, RsrConnectionClosedBeforeReceivingResponse is a subclass of RsrAbstractReason not Error. Since the client is effective dead, I think this should be an error to tell the client (and consequently the user) to take more aggressive recovery action.

@ericwinger ericwinger added the enhancement New feature or request label Mar 19, 2024
@ericwinger
Copy link
Member Author

I suppose it would be more proper to request that the class become a subclass of RsrRemoteException

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants