Don't fail when What4 sends us a function-based array in a result. #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauclovian-g
added
error-messages
usability
RyanGlScott
approved these changes
Sep 12, 2024
| -- it should be implemented in What4 so What4 never returns | ||
| -- ArrayMapping. | ||
| -- | ||
| -- (See note in FiniteValue.hs where FirstOrderValue lives.) |
There was a problem hiding this comment.
To make this more obvious:
Suggested change
| -- (See note in FiniteValue.hs where FirstOrderValue lives.) | |
| -- (See Note [FOVArray] in saw-core:Verifier.SAW.FiniteValue.) |
| -- | ||
| -- FOVOpaqueArray is for arrays we get back from the solver only as a | ||
| -- function call that one can use for lookups. We can't do anything | ||
| -- with that (see notes below) so we just treat it as an opaque blob. |
There was a problem hiding this comment.
Suggested change
| -- with that (see notes below) so we just treat it as an opaque blob. | |
| -- with that (see Note [FOVArray]) so we just treat it as an opaque blob. |
We can't store function-based arrays in FirstOrderValue for a number of reasons. But we also can't do anything much useful with them, so if we get one (unfortunately this does happen, which may or may not be amenable to improvement in What4) treat it as an opaque blob. Add an FOVOpaqueArray to FirstOrderValue for this. The footprint of having this undesirable object is not large, so it's the path of least resistance. We could in principle instead return something other than a FirstOrderValue out of groundToFOV for this case, if we had a use for the actual function, but since we can't do anything much with the function because we have no idea what keys to look up, there doesn't seem to be any point.
sauclovian-g
force-pushed
the
2120-function-arrays
branch
from
6be8c80
to
d489ee3
Compare
|
(force-pushed to squash) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit for description)
Fixes #2120.