From 1882b75ff8caa3e01be0abb92c6f8b96eb4e7f21 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Fri, 21 Jun 2024 08:24:36 -0400 Subject: [PATCH 1/3] Update to ESMA_cmake v3.46.0 --- CHANGELOG.md | 13 +++++++------ components.yaml | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6b369229e267..87111de378b8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,27 +9,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added -- Add new option to Regrid_Util.x to write and re-use ESMF pregenerated weights -- If file path length exceeds ESMF_MAXSTR, add `_FAIL` in subroutine fglob +- Add new option to `Regrid_Util.x` to write and re-use ESMF pregenerated weights +- If file path length exceeds `ESMF_MAXSTR`, add `_FAIL` in subroutine fglob - Add GNU UFS-like CI test -- Add capability to mangle `LONG_NAME in ACG with a different prefix +- Add capability to mangle `LONG_NAME` in ACG with a different prefix ### Changed -- fixed a bug in generate_newnxy in MAPL_SwathGridFactory.F90 (`NX*NY=Ncore`) - pFIO Clients don't send "Done" message when there is no request - Update `components.yaml` - - ESMA_cmake v3.45.3 + - ESMA_cmake v3.46.0 - Fix bugs in meson detection - Fix for building on older macOS + - Add `esma_add_fortran_submodules` function - Updated `checkpoint_simulator` to not create and close file if not writing - Update ExtData tests - Add new category of `SLOW` tests that take 10-30 seconds and remove them from the `ESSENTIAL` label run in CI - - Remove ExtData1G tests from `ESSENTIAL` label + - Remove ExtData1G tests from `ESSENTIAL` label, but run them in the UFS-like CI test ### Fixed +- Fixed a bug in `generate_newnxy` in `MAPL_SwathGridFactory.F90` (`NX*NY=Ncore`) - Fixes for NVHPC 24.5 - Convert `MAPL_GeosatMaskMod` to "interface-in-both-files" submodule style diff --git a/components.yaml b/components.yaml index b6a9bb01aa21..bf46f2c95c5d 100644 --- a/components.yaml +++ b/components.yaml @@ -11,7 +11,7 @@ ESMA_env: ESMA_cmake: local: ./ESMA_cmake remote: ../ESMA_cmake.git - tag: v3.45.3 + tag: v3.46.0 develop: develop ecbuild: From f47996a780ab0c986660d8cccdb0915a895e6101 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Fri, 21 Jun 2024 09:56:55 -0400 Subject: [PATCH 2/3] Remove explicit esma_add_fortran_submodules --- generic3g/CMakeLists.txt | 29 +---------------------------- 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/generic3g/CMakeLists.txt b/generic3g/CMakeLists.txt index 69833229802b..bd5170fc94d2 100644 --- a/generic3g/CMakeLists.txt +++ b/generic3g/CMakeLists.txt @@ -59,33 +59,6 @@ esma_add_library(${this} TYPE SHARED ) -##### New function to avoid conflicts with files with the same name -function(esma_add_fortran_submodules) - set(options) - set(oneValueArgs TARGET SUBDIRECTORY) - set(multiValueArgs SOURCES) - cmake_parse_arguments( - ARG "${options}" "${oneValueArgs}" - "${multiValueArgs}" ${ARGN} - ) - - foreach(file ${ARG_SOURCES}) - - set(input ${CMAKE_CURRENT_SOURCE_DIR}/${ARG_SUBDIRECTORY}/${file}) - set(output ${CMAKE_CURRENT_BINARY_DIR}/${ARG_SUBDIRECTORY}_${file}) - add_custom_command( - OUTPUT ${output} - COMMAND ${CMAKE_COMMAND} -E copy ${input} ${output} - DEPENDS ${input} - ) - set_property(SOURCE ${output} PROPERTY GENERATED 1) - target_sources(${ARG_TARGET} PRIVATE ${output}) - - endforeach() - -endfunction() -##### - add_subdirectory(specs) add_subdirectory(registry) add_subdirectory(connection) @@ -97,7 +70,7 @@ add_subdirectory(GriddedComponentDriver) esma_add_fortran_submodules( TARGET MAPL.generic3g SUBDIRECTORY OuterMetaComponent - SOURCES SetServices.F90 add_child_by_name.F90 new_outer_meta.F90 init_meta.F90 + SOURCES SetServices.F90 add_child_by_name.F90 new_outer_meta.F90 init_meta.F90 get_child_by_name.F90 run_child_by_name.F90 run_children.F90 get_outer_meta_from_outer_gc.F90 attach_outer_meta.F90 free_outer_meta.F90 get_phases.F90 set_hconfig.F90 get_hconfig.F90 get_geom.F90 From ea6514903fb7483c711d2358a7d2ffc22ee11d63 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Fri, 21 Jun 2024 11:11:52 -0400 Subject: [PATCH 3/3] Try and fix CI --- .circleci/config.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 2ad7a6ce9ada..7bb628671075 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -93,6 +93,7 @@ workflows: baselibs_version: *baselibs_version repo: GEOSgcm checkout_fixture: true + fixture_branch: release/MAPL-v3 mepodevelop: true checkout_mapl3_release_branch: true checkout_mapl_branch: true