Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chem_UtilMPRead appears to be unused code #167

Open
bena-nasa opened this issue Feb 25, 2022 · 1 comment
Open

Chem_UtilMPRead appears to be unused code #167

bena-nasa opened this issue Feb 25, 2022 · 1 comment
Assignees
@amdasilva @mmanyin @pcolarco

Comments

@bena-nasa
Copy link
Collaborator

bena-nasa commented Feb 25, 2022 •
edited
Loading

While looking at where MAPL_CFIORead was still used I noticed that it was still used by Chem_UtilMPRead_g5.
However, as far as I can tell this particular routine is not used anywhere in this repository or in other repos such as gocart or GEOSchem. It should be deleted if not being used.
@mmanyin
Copy link
Contributor

mmanyin commented Mar 4, 2022

Having scanned the code for GCM, CTM, ADAS, LDAS and DYCORE, I cannot see anywhere that Chem_UtilMPread_g5 or Chem_UtilMPread are used. Any objection to my removing them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amdasilva amdasilva

@mmanyin mmanyin

@pcolarco pcolarco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amdasilva @bena-nasa @mmanyin @pcolarco