Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review mapp/ui css for theming #1599

Open
dbauszus-glx opened this issue Oct 23, 2024 · 1 comment
Open

Review mapp/ui css for theming #1599

dbauszus-glx opened this issue Oct 23, 2024 · 1 comment
Labels
CSS Changes in stylesheets

Comments

@dbauszus-glx
Copy link
Member

The mapp and the ui css in particular is a mess.

Things have been added in an unsttructured manner without review and outdated rules have never been removed.

The dialog for example has a white background colour [#fff] which makes it impossible to theme this by prepending or appending css rules to the document head.

The number of colours should be reviewed. The more colours we add the more chaotic theming becomes.

The idea of theming is that each colour has a lookup colour.

Colours should be assigned as classes.

Instead of n classes having n different background colours it is much easier to use a background-colour class for a background colour which can easily be exchanged by appending theme rules.

@dbauszus-glx dbauszus-glx added the CSS Changes in stylesheets label Oct 23, 2024
@dbauszus-glx
Copy link
Member Author

I have created a PR for the dialog example.

#1600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Changes in stylesheets
Projects
None yet
Development

No branches or pull requests

1 participant