Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge vector_layer entry method with layer entry method #1586

Open
dbauszus-glx opened this issue Oct 18, 2024 · 1 comment
Open

Merge vector_layer entry method with layer entry method #1586

dbauszus-glx opened this issue Oct 18, 2024 · 1 comment
Assignees
Labels
Code Issues related to the code structure and performance. Deprecated Features which are no longer supported and should eventually be removed. Feature New feature requests or changes to the behaviour or look of existing application features.

Comments

@dbauszus-glx
Copy link
Member

The vector_layer entry and mvt_clone entry type should essentially work the same but are quite different at the moment.

The vector_layer doesn't support themes.

There is a lot of duplicate code which is hard to maintain.

The layer entry method replaces the mvt_clone method. #1268

This method however does not allow for layer queries without the layer already being defined in the workspace.

The vector_layer entry method should be deprectated in support of the layer entry method once it is possible to load layer data from a layer entry object without the layer being added to the workspace locale first.

@dbauszus-glx dbauszus-glx added Feature New feature requests or changes to the behaviour or look of existing application features. Code Issues related to the code structure and performance. Deprecated Features which are no longer supported and should eventually be removed. labels Oct 18, 2024
@dbauszus-glx dbauszus-glx self-assigned this Oct 18, 2024
@dbauszus-glx
Copy link
Member Author

The vector_layer / layer entry method must support a reload method which will request the data from the query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance. Deprecated Features which are no longer supported and should eventually be removed. Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

No branches or pull requests

1 participant