Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instances are sometimes wrong #95

Open
lenasauermann opened this issue Sep 4, 2024 · 8 comments · May be fixed by #111
Open

Instances are sometimes wrong #95

lenasauermann opened this issue Sep 4, 2024 · 8 comments · May be fixed by #111
Assignees

Comments

@lenasauermann
Copy link
Contributor

Some instances are wrong! Codeowners, please check your instances again!

Our developers need correct test data ;)

@lenasauermann
Copy link
Contributor Author

lenasauermann commented Sep 6, 2024

SD Creation Wizard might generate the JSONs wrong

@lenasauermann
Copy link
Contributor Author

@robertschubert can we integrate a check "are there any additional claims beside what is defined in the shacl" to the json vs. shacl check?

@lenasauermann lenasauermann self-assigned this Sep 6, 2024
@robertschubert
Copy link
Collaborator

@lenasauermann
It would helf if you specifiy the ontologies where you spotted a concrete error :)

To your question, if we can adjust the validation:
Yes, we can do this with the help of sh:closed true.
Example:

ex:MyShape a sh:NodeShape ;
    sh:targetClass ex:MyClass ;
    sh:closed true ; # Activates the strict validation so additional fields in the jsonld are not allowed anymore.

Each domain (functional code owner) needs to decide if they want to have a closed definition or not.

@lenasauermann
Copy link
Contributor Author

When we add sh:closed true, we would see every error, right? :D I can try to write down/mark every error but I propably oversee a few...

@lenasauermann
Copy link
Contributor Author

Scenario:

Im type Scenario:scenario --> müsste Scenario:Scenario sein. Ist schon im shacl falsch!

general:DataResource --> just wrong, does not need to be there

general:media --> doubles at the end

georeference:georeference --> doubles too

OsiTrace:

startTime nicht korrekt

HdMap:

in "hdmap:general" ist "general:media", "general:requiredData" und "hdmap:speedLimit" fälschlicherweise drin

@lenasauermann
Copy link
Contributor Author

@heuerfin @rcrswld Can you take care about Scenario... there are the most errors (even in the shacl)

pmai added a commit that referenced this issue Sep 20, 2024
Addresses #95 for ositrace

Signed-off-by: Pierre R. Mai <[email protected]>
@robertschubert
Copy link
Collaborator

ein funktionierend hdmap-example anbei
hdmap-working.json

@MircoNierenz
Copy link
Contributor

have created a branch, will fix hdmap, scenario, surface there
georeference and environment-model are currently in separate pull requests.

@MircoNierenz MircoNierenz linked a pull request Oct 25, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants