Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkShape alows to define or describe there an link to the location of the asset #69

Open
jtdemer opened this issue Jun 28, 2024 · 5 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@jtdemer
Copy link
Collaborator

jtdemer commented Jun 28, 2024

In the general domain we have defined an LinkShape which alows to define or describe there an link to the location of the asset.

I have folllowing concerns about that:

  • Is this the right place to provide the asset location link?
  • How do we protect the asset from unauthorized downloads?
  • Should be that link availible in a public catalogue?
general:LinkShape a sh:NodeShape ;
    sh:property [ sh:datatype xsd:string ;
            sh:in ("Document" "Image" "Model" "Routing" "Video" "3DPreview" "Asset") ;
            sh:message "Validation of type failed!"@en ;
            sh:description "Choose type of link." ;
            sh:name "type"@en ;
            sh:order 1 ;
            sh:maxCount 1 ;
            sh:minCount 1 ;
            sh:path general:type ],
        [ sh:datatype xsd:anyURI ;
            sh:message "Validation of url failed!"@en ;
            sh:description "Enter link as URL or DID." ;
            sh:name "url"@en ;
            sh:order 0 ;
            sh:maxCount 1 ;
            sh:minCount 1 ;
            sh:path general:url ] ;
    sh:targetClass general:Link .

An example of how data providers interpret this is already available here:
https://github.com/GAIA-X4PLC-AAD/hd-map-asset-example/blob/main/metadata/Gaia_X_Example_Asset_TestfeldNiedersachsen_ALKS_ODR_offset.json

@jtdemer jtdemer added the help wanted Extra attention is needed label Jun 28, 2024
@rcrswld
Copy link
Collaborator

rcrswld commented Jun 28, 2024

@jtdemer I have created in issue going in the same direction as yours here:
GAIA-X4PLC-AAD/hd-map-asset-example#7

@robertschubert proposed some ways of solving the issue over there.

@jtdemer
Copy link
Collaborator Author

jtdemer commented Jun 28, 2024

@jtdemer I have created in issue going in the same direction as yours here: GAIA-X4PLC-AAD/hd-map-asset-example#7

@robertschubert proposed some ways of solving the issue over there.

Thx @rcrswld but I think we should fix it here in the general ontology as well

@robertschubert
Copy link
Collaborator

@jtdemer please see my comment in the other repo.
please close the issue if ok for you. If not, we should talk.

@rcrswld
Copy link
Collaborator

rcrswld commented Jul 1, 2024

Would it help if we add in the documentation that data providers shall not use the 'url'-property to directly refer to their asset (apart from open-data)?

@robertschubert
Copy link
Collaborator

it depends what the providers want to expose or not - please see my answer in the GAIA-X4PLC-AAD/hd-map-asset-example#7
In general I do not think they want to provide a link to an asset which is hosted anywhere in a web server without any access control. Lets discuss this in our meeting on Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants