Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario Ontology: Link to OpenDRIVE map #47

Open
jdsika opened this issue Jun 7, 2024 · 9 comments · Fixed by #51
Open

Scenario Ontology: Link to OpenDRIVE map #47

jdsika opened this issue Jun 7, 2024 · 9 comments · Fixed by #51
Assignees

Comments

@jdsika
Copy link
Contributor

jdsika commented Jun 7, 2024

I am looking at the following element:

"scenario:trafficSpace": {
      "@type": "general:Link",
      "general:url": {
        "@value": "https://inavlid.link.com/my_map.xodr",
        "@type": "xsd:anyURI"
      },
      "general:type": "Document"
    }

I think a map is its own asset with its own meta data description. In this case we would depend with a scenario on a map that has already been instantiated as a separate asset and should be referenced through the asset id?

Maybe @lenasauermann has an opinion here as well?

@heuerfin
Copy link
Contributor

Yes, we thought of that too. And we would also prefer to use the DID as a link. However, we weren't sure if xsd:anyURI is the correct type for a DID.
According to https://www.w3.org/TR/did-core/ "DIDs are URIs that associate a DID subject with a DID document allowing trustable interactions associated with that subject." so the xsd:anyURI would be probably appropriate.

According to https://www.ietf.org/rfc/rfc2396.txt I found the following regex for URI ^(([^:/?#]+):)?(//([^/?#]*))?([^?#]*)(\?([^#]*))?(#(.*))?.
Using https://www.regextester.com/ and the sample DID did:web:registry.gaia-x.eu:ExampleServiceOffering:tbkmzxk9LQZ-6mfDovXUPycG7hpE639RFRFs this matches.

From this I would conclude that this is okay then? Are there any other opinions? Othewise I would change it and create a pull request.

@jdsika
Copy link
Contributor Author

jdsika commented Jun 12, 2024

@robertschubert what is your opinion? It makes sense to me. What did method should we use for assets?

@heuerfin
Copy link
Contributor

I just talked wit @lenasauermann about it. I'll create a new branch and use a DID.

@jdsika
Copy link
Contributor Author

jdsika commented Jun 12, 2024

The other question is if we want to define "asset bundles" in a generic way. So remove these nested links and remove a separate ontology for a bundle?

@heuerfin heuerfin linked a pull request Jun 12, 2024 that will close this issue
3 tasks
@heuerfin
Copy link
Contributor

I'm not sure about that one. Last time we discussed this, we concluded that we will not use bundles inside our ontology. The ontology however, should offer the oppertunity to modell required and optional "dependencies" or links. A data provider/marketplace can then offer a bundle based on these dependencies.

However, we can reopen that discussion.

@jdsika
Copy link
Contributor Author

jdsika commented Jun 12, 2024

I am ok if you discussed it!

@jdsika
Copy link
Contributor Author

jdsika commented Jun 13, 2024

@jdsika jdsika reopened this Jun 13, 2024
@heuerfin
Copy link
Contributor

@lenasauermann
Copy link
Contributor

@heuerfin @jdsika Is this done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants