Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable optimised builds when compiling from didChange events. #6576

Open
JoshuaBatty opened this issue Sep 21, 2024 · 0 comments
Open

Reenable optimised builds when compiling from didChange events. #6576

JoshuaBatty opened this issue Sep 21, 2024 · 0 comments
Labels
bug Something isn't working language server LSP server

Comments

@JoshuaBatty
Copy link
Member

After solving a bug in #6575 that was crashing the server on did save events, I noticed that we do not return any diagnostics to the user.

Iv'e played around for a while but it's not obvious to me the best way to solve this. Considering we have a code freeze coming up i'm temporarily disabling this optimisation so we can continue to show error and warning diagnostics to the user while I investigate.
@JoshuaBatty JoshuaBatty added bug Something isn't working language server LSP server labels Sep 21, 2024
@JoshuaBatty JoshuaBatty mentioned this issue Sep 21, 2024
Merged
8 tasks
JoshuaBatty added a commit that referenced this issue Sep 21, 2024
@JoshuaBatty
fix OOB slab panic when creating runnables on a did_save event (#6575)
3a6e937 
## Description
I noticed that the language server would crash when compilation was
triggered from a did save event as we were trying to create runnables
from the Engines that had GC applied to it. We now check to ensure that
the correct Engines is accessed to avoid a panic when creating
runnables.

After fixing this bug, I noticed that optimised builds was not returning
diagnostics. I've opened #6576 to work on this and have temporarily
disabled the optimisation so diagnostics continue to work.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working language server LSP server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaBatty