Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wallet support more transaction formats #1521

Closed
LuizAsFight opened this issue Sep 27, 2024 · 0 comments · Fixed by #1523
Closed

Make wallet support more transaction formats #1521

LuizAsFight opened this issue Sep 27, 2024 · 0 comments · Fixed by #1523
Assignees
@LuizAsFight
Labels
bug Something isn't working

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Sep 27, 2024 •
edited
Loading

When the transaction arrives to the fuel Wallet:

  • we estimate the cost of it and put a maxFee bigger than the one estimated
  • we try dryrun this estimated transaction
    • then the problem in print happens.
    • we should try using the initial transaction as back up

this is needed to unblock fuel wallet connector in mira app

image.png
@LuizAsFight LuizAsFight added the bug Something isn't working label Sep 27, 2024 — with Linear
@LuizAsFight LuizAsFight changed the title make estimation part of approve transaction dont cause error when its coming from dapp Make wallet support more transaction formats Sep 28, 2024
@LuizAsFight LuizAsFight mentioned this issue Sep 28, 2024
Merged
LuizAsFight added a commit that referenced this issue Sep 28, 2024
@LuizAsFight
fix: wallet bulletproof (#1523)
76dd46d 
- Closes #1521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuizAsFight LuizAsFight

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wallet bulletproof FuelLabs/fuels-wallet
1 participant
@LuizAsFight