Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CombinedDatabase): handle errors on rolling back auxiliary dbs appropriately #2239

Open
1 task
rymnc opened this issue Sep 23, 2024 · 0 comments
Open
1 task

chore(CombinedDatabase): handle errors on rolling back auxiliary dbs appropriately #2239

rymnc opened this issue Sep 23, 2024 · 0 comments
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@rymnc
Copy link
Member

rymnc commented Sep 23, 2024

On b2aa337#diff-c9ec92d6a50c589b6cf389155213049e62dffd865cb2aaf85ebf35a1c74298eaR319-R321

we attempt to sync auxiliary databases with the OnchainDb however, we do not handle errors while doing so.

Definition of Done

  • Rolling back errors are propagated and if on_chain_height / gas_price_height / off_chain_height is unset, swallow the errors
@rymnc rymnc added the tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. label Sep 23, 2024
@rymnc rymnc mentioned this issue Sep 23, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rymnc