Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Set Locale from HTML-lang-attribute when used with international routing #486

Open
mkrauser opened this issue Sep 19, 2024 · 1 comment

Comments

@mkrauser
Copy link

We have international routes enabled in our project and we use FosJsRouting with encore like this:

// webpack.config.js
  ...
  .addPlugin(
    new FosRouting({
      locale: "de",
      target: "var/cache/frontend/fosRoutes.json",
    })
  )

I thought, that the locale given here is just the default (or fallback) locale, but this is not the case.
And there is not documented way, of setting the locale after Routing has been initialized. I tried calling Routing.setLocale manually, but the routes were loaded after that by webpack so my setting was overridden.
It would be nice, if the current locale can be read from html-tag attributes (like the symfony ux translator bundle: https://github.com/symfony/ux/blob/412da630824772f1fcb4d363b24b243a7165c4a0/src/Translator/assets/src/translator.ts#L47)

@mkrauser
Copy link
Author

Here's a working solution, using the webpack-inject-plugin:

// webpack.config.js
const InjectPlugin = require('@bpnetguy/webpack-inject-plugin').default;

    ...
    .addPlugin(
        new FosRouting({
            locale: "de",
            target: "var/cache/frontend/fosRoutes.json",
        })
    )
    .addPlugin(
        new InjectPlugin(
            () => 'import Routing from "fos-router"; Routing.setLocale(' +
                'document.documentElement.getAttribute("data-symfony-ux-translator-locale") || ' +
                'document.documentElement.lang || ' +
                '"de"' +
                ');'
        )
    )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant