Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting doesn't work if data for both axis is numeric #2881

Open
2 tasks done
kazimirchuk opened this issue Jul 1, 2024 · 1 comment
Open
2 tasks done

Sorting doesn't work if data for both axis is numeric #2881

kazimirchuk opened this issue Jul 1, 2024 · 1 comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@kazimirchuk
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Victory version

Latest

Code Sandbox link

https://codesandbox.io/s/victory-starter-forked-l73jld?file=/src/App.tsx

Bug report

Sorting doesn't work if data for both axis is numeric.

Steps to reproduce

1. Go to a "Getting Started" page of Victory
2. Go to Step #3 "Add your data"
3. Confirm that chart data that you see follows this `interface { earnings: number; quarter: number }`
4. Try adding an attribute `sortKey` with the value of `earnings` to the `VictoryBar`
5. Confirm that it doesn't sort
6. Now edit chart data so that it follows this `interface { earnings: number; quarter: string }`
7. Confirm that it started sorting

Expected behavior

It should sort the data by specified `sortKey`

Actual behavior

It doesn't sort the data by specified `sortKey`

Environment

- Device:
- OS:
- Node:
- npm:
@kazimirchuk kazimirchuk added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Jul 1, 2024
@kazimirchuk
Copy link
Author

sorting_does_not_work.MOV

@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

2 participants