Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG files, make theme specific versions of the svg files. #6

Open
homberghp opened this issue Feb 20, 2024 · 0 comments · May be fixed by #14
Open

SVG files, make theme specific versions of the svg files. #6

homberghp opened this issue Feb 20, 2024 · 0 comments · May be fixed by #14

Comments

@homberghp
Copy link
Contributor

homberghp commented Feb 20, 2024

Theme switching, for instance in dark mode changes the colors in the svgs

To be able to reason about the diagram, where the diagram uses color to distinguish element types,
we should add a legend of the color use in the diagram to each diagram.
Also do not refer to the colors by name, because e.g. green will render magenta in dark mode.

In the diagram below we added yellow and green for interfaces and classes

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant