Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly interpolate TypeBind #201

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

lassepe
Copy link
Contributor

@lassepe lassepe commented Mar 19, 2024

Resolves #30

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (2b843b2) to head (4b755b5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   79.72%   79.48%   -0.24%     
==========================================
  Files          10       10              
  Lines         429      429              
==========================================
- Hits          342      341       -1     
- Misses         87       88       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassepe
Copy link
Contributor Author

lassepe commented Mar 19, 2024

cc @cstjean

@cstjean
Copy link
Collaborator

cstjean commented Mar 21, 2024

Thanks! Would you mind adding a test? I think

module TestSubModule
import MacroTools: @capture
...
end

would do the trick.

@lassepe
Copy link
Contributor Author

lassepe commented Mar 21, 2024

I added a test. I verified that it indeed fails without this patch.

@cstjean cstjean merged commit c9f9e98 into FluxML:master Mar 22, 2024
11 of 12 checks passed
@lassepe lassepe deleted the fix/interpolation branch March 22, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacroTools not defined
2 participants