Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AttributeError when using LOGGING_CONFIGURATION_FILE environment variable #4693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: AttributeError when using LOGGING_CONFIGURATION_FILE environment variable #4693

wants to merge 1 commit into from

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 3, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #4692.

How did you test this code?

Ran Flagsmith with LOGGING_CONFIGURATION_FILE as per the issue description.

@khvn26 khvn26 requested a review from a team as a code owner October 3, 2024 15:30
@khvn26 khvn26 requested review from matthewelwell and removed request for a team October 3, 2024 15:30
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 3, 2024 3:30pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 3, 2024 3:30pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 3, 2024 3:30pm

@github-actions github-actions bot added the api Issue related to the REST API label Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4693 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4693 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4693 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4693 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4693 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4693 Finished ✅ Results ✅

@github-actions github-actions bot added the fix label Oct 3, 2024
@khvn26 khvn26 mentioned this pull request Oct 3, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

Uffizzi Ephemeral Environment deployment-56892

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4693

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.20%. Comparing base (e65c8da) to head (8dcc947).

Files with missing lines Patch % Lines
api/util/logging.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4693   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files        1171     1171           
  Lines       40640    40640           
=======================================
  Hits        39506    39506           
  Misses       1134     1134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell Awaiting requested review from matthewelwell matthewelwell is a code owner automatically assigned from Flagsmith/flagsmith-back-end

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api Issue related to the REST API fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError when using LOGGING_CONFIGURATION_FILE environment variable
1 participant
@khvn26