Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage Override Not Saved When Modifying Segments #4655

Open
1 of 4 tasks
ezgishere opened this issue Sep 24, 2024 · 0 comments · May be fixed by #4709
Open
1 of 4 tasks

Percentage Override Not Saved When Modifying Segments #4655

ezgishere opened this issue Sep 24, 2024 · 0 comments · May be fixed by #4709
Assignees
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard

Comments

@ezgishere
Copy link

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

There's an issue in Flagsmith where percentage settings are not retained if you remove a segment and add a new one without saving changes in between.

The issue occurs when you remove and add a new segment without saving the changes after removing the initial segment. A screen recording has been attached for reference.

Steps To Reproduce

Steps to Reproduce:

  1. Remove an existing segment (e.g., experiment-users).
  2. Add a new segment (e.g., s1_experiment_users) and turn it on.
  3. Set the percentage for each variant (e.g., 20% for each).
  4. Click on "Update Segment Override."
  5. Navigate away and return to the flag settings.

Actual Behavior: All percentages revert to 0%, requiring manual re-entry of the desired values.

Expected behavior

Expected Behavior: The set percentages (20% for each variant) should be saved and reflected correctly.

Screenshots

Screen.Recording.2024-09-24.at.11.47.23.mov
@ezgishere ezgishere added the bug Something isn't working label Sep 24, 2024
@matthewelwell matthewelwell added the front-end Issue related to the React Front End Dashboard label Sep 27, 2024
@kyle-ssg kyle-ssg linked a pull request Oct 9, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants