Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package-lock.json files to .gitignore configuration #339

Closed
wants to merge 2 commits into from
Closed

Add package-lock.json files to .gitignore configuration #339

wants to merge 2 commits into from

Conversation

i-like-robots
Copy link
Contributor

@i-like-robots i-like-robots commented Jun 11, 2019 •
edited
Loading

As it says! Fixes #329.

@i-like-robots i-like-robots added the housekeeping Cleaning things up label Jun 11, 2019
@i-like-robots i-like-robots mentioned this pull request Jun 11, 2019
Open
@i-like-robots i-like-robots changed the title Add package-lock.json files to .gitignore configuration, fixes #239 Add package-lock.json files to .gitignore configuration Jun 11, 2019
benbarnett
benbarnett approved these changes Jun 11, 2019
View reviewed changes
.gitignore
npm-debug.log
bower_components/
node_modules/
dist/
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always feel this should live in a global config on dev machines rather than being a project concern. Belt and braces though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! But yes, belt and braces

@apaleslimghost
Copy link
Member

apaleslimghost commented Jun 11, 2019 •
edited
Loading

"fixes #239"? sure you've got the right issue number?

edit: ah, you meant #329.

apaleslimghost
apaleslimghost requested changes Jun 11, 2019
View reviewed changes
Copy link
Member

@apaleslimghost apaleslimghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think adding it to the .gitignore is the right approach. yes, it prevents people from committing it, but they'll still have the problems it causes locally.

@i-like-robots
Copy link
Contributor Author

i-like-robots commented Jun 11, 2019 •
edited
Loading

Good point, but the issue referenced is specifically about issues caused by committing these files so this should fix that.

In Anvil we have sprinkled .npmrc files around the place to disable lockfiles, shall I add one to the repo root? we already have one.

@jenniferemshepherd
Copy link
Contributor

so... we merging this?

@edds
Copy link
Contributor

edds commented Oct 22, 2019

This PR is being closed due to inactivity as part of a Pull Request Bankruptcy. If you feel it’s still useful or relevant please feel free to re-open it.

@edds edds closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaleslimghost apaleslimghost apaleslimghost requested changes

@benbarnett benbarnett benbarnett approved these changes

Assignees
No one assigned
Labels
housekeeping Cleaning things up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use a precommit hook to prevent package-lock.json files being committed
5 participants
@i-like-robots @apaleslimghost @jenniferemshepherd @edds @benbarnett