Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier can change formatting to something that eslint doesn't like #252

Open
apaleslimghost opened this issue Feb 5, 2019 · 1 comment
Labels
enhancement New feature or request housekeeping Cleaning things up

Comments

@apaleslimghost
Copy link
Member

which, if you have your editor configured to run prettier on save, makes writing code that passes the tests a bit of a pain. we should consider using something like xo, which keeps eslint and prettier in sync, and has a default style that's pretty close to ours anyway. we should also think about enforcing style with a git hook?

@apaleslimghost apaleslimghost added enhancement New feature or request housekeeping Cleaning things up labels Feb 5, 2019
@apaleslimghost
Copy link
Member Author

since this issue i've created a pretty good personal setup with lint-staged and eslint-preset-prettier https://gist.github.com/apaleslimghost/f574c6d429f6ced18593eed5e5432d2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping Cleaning things up
Projects
None yet
Development

No branches or pull requests

1 participant