ACCEPT_CASE_INSENSITIVE_PROPERTIES is not respected for creator properties

[apatrida]

reported in FasterXML/jackson-module-kotlin#47

When creators with properties are used, databind assumes that the name returned for hte property is literal (i.e. provided with JsonProperty annotation) but in cases where properties are provided implicitly (Java 8, or Kotlin Module) this is not the case, the target property name is provided.

So when the ACCEPT_CASE_INSENSITIVE_PROPERTIES feature is used anything that has a case mismatch fails.

in BeanDeserializer

// in BeanDeserializer...

SettableBeanProperty creatorProp = creator.findCreatorProperty(propName);
// null is returned
if (creatorProp != null) {
                  ...
}

which calls findCreatorProperty() in PropertBasedCreator:

public SettableBeanProperty findCreatorProperty(String name) {
        // fails because does not do case insensitive check when ACCEPT_CASE_INSENSITIVE_PROPERTIES is true
        return _propertyLookup.get(name);
    }

The hash lookup does not use the value of this feature switch like it does when looking for properties to be set after construction.

[cowtowncoder]

Hmmh. So... Feature ACCEPT_CASE_INSENSITIVE_PROPERTIES refers to matching of differing case property names from data (json etc) into POJO properties -- so that input property "Foo" would match POJO property of foo. But handling of properties during construction of deserializers is different, so I wonder if this extends to matching of case-specific names; like getter "getFileName()" vs "setFilename()"...
Looking at code, those should get canonicalized. So maybe it's just a question of creator-properties not getting properly mangled.

[cowtowncoder]

Can reproduce as suggested; add a failing test and hope troubleshoot some more.

[cowtowncoder]

Fixed by adding handling in the missing place, PropertyBasedCreator.