Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag/drop functionality to ImageWell #488

Open
forresthopkinsa opened this issue May 20, 2021 · 3 comments
Open

Add drag/drop functionality to ImageWell #488

forresthopkinsa opened this issue May 20, 2021 · 3 comments

Comments

@forresthopkinsa
Copy link
Contributor

The ImageWell component was added for use with tv-management / live stream. The specs for that project (i.e. here) call for drag/drop ability on the image selectors. Can we pull in the drag/drop abilities of other components e.g. DropZone for ImageWell? Would this be practical given the current signature of the ImageWell component?

@RobertBolender
Copy link
Contributor

You've convinced me that it belongs on this component, and it sounds workable to me.
Would you think of this as a "variant", or would you have thoughts about what the props for it would look like?

@forresthopkinsa
Copy link
Contributor Author

I haven't used the DropZone component, so I'm not very familiar with its nuances, but from glancing at the documentation it seems like it would be sufficient to adopt that pattern in the ImageWell and leave it up to the consumer to set the previewUrl state based on the dropped files.

However, I would be interested to see how DropZone or FilesSection is being used with Amber today – if either of them are, in fact, being used with Amber anywhere. Do you happen to know of any examples of that?

@RobertBolender
Copy link
Contributor

I'm not personally aware of existing usages with Amber but I know there are pending specs for implementing a DropZone feature into the shared AssetPicker component, but that is not yet developed.

Based on this GitHub Enterprise search, it's possible that this DropZone component is totally unused?
https://git.faithlife.dev/search?q=DropZone+styled-ui&type=code

FilesSection has a handful of uses, in ChMS, Soundfaith (renamed Sermons?) and FaithlifeMusic:
https://git.faithlife.dev/search?q=FilesSection+styled-ui&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants