Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we deprecate FairGeoInterface::{createGeometry,createAll,deleteSet} #1538

Open
ChristianTackeGSI opened this issue May 17, 2024 · 0 comments
Open

Can we deprecate FairGeoInterface::{createGeometry,createAll,deleteSet} #1538

ChristianTackeGSI opened this issue May 17, 2024 · 0 comments
Labels
Refactor Code needs to be reworked

Comments

@ChristianTackeGSI
Copy link
Member

ChristianTackeGSI commented May 17, 2024 •
edited
Loading

All don't look like they're used.

Both create* take a strange cleanup argument that deletes the GeoSet right after setting it up?

If they're actually meant to be called by users, please provide an example.
@ChristianTackeGSI ChristianTackeGSI changed the title Can we deprecate FairGeoInterface::{createGeometry,createGeometry} Can we deprecate FairGeoInterface::{createGeometry,createAll} May 17, 2024
@ChristianTackeGSI ChristianTackeGSI changed the title Can we deprecate FairGeoInterface::{createGeometry,createAll} Can we deprecate FairGeoInterface::{createGeometry,createAll,deleteSet} May 17, 2024
@fuhlig1 fuhlig1 added the Refactor Code needs to be reworked label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Code needs to be reworked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fuhlig1 @ChristianTackeGSI