Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WoodTypeBuilder suggests using private register method #3954

Open
haykam821 opened this issue Jul 19, 2024 · 2 comments
Open

WoodTypeBuilder suggests using private register method #3954

haykam821 opened this issue Jul 19, 2024 · 2 comments

Comments

@haykam821
Copy link
Contributor

haykam821 commented Jul 19, 2024

The WoodTypeBuilder#build method mentions using the WoodType.register method:

However, the access widener for this method is not transitive, meaning it is private to API consumers:

accessible method net/minecraft/block/WoodType register (Lnet/minecraft/block/WoodType;)Lnet/minecraft/block/WoodType;

Note that the test mod uses this method, so the test mod currently does not provide a working example of using this API:

@apple502j
Copy link
Contributor

What would happen to the build method then?

@haykam821
Copy link
Contributor Author

The WoodTypeBuilder#build method could be kept if the access widener is made transitive. I would imagine that solution would be preferred over leaving WoodTypeBuilder#build useless and updating the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants