Blockentity client rendering out of sync in 1.17 fabric

[theAfish]

Hi all,

I am new to modding. Recently I am trying to make a blockentity following the example on fabric-wiki (https://fabricmc.net/wiki/tutorial:blockentityrenderers). I want to make a change that when I hold an item and right-click this blockentity, this item can show on top of it (like the item frame).

However, the item won't show until I reload the chunk, which is due to the data is not sync between the server and client. I found that using the interface "BlockEntityClientSerializable" should help. So I implemented it and wrote the fromClientTag and toClientTag methods. However, it didn't have any effect. Then I copied MixinBlockEntity.java and MixinClientPlayNetworkHandler.java files in fabric-networking-blockentity-v0 into my own code. But Minecraft crashed.

Could anyone tell me how could I render the changing of blockentity correctly? And what is happening for the Mixin files? Thank you very much!

The crash report is attached here
crash-2021-11-03_12.15.46-client.txt
e

[warjort]

The MixinClientPlayNetworkHandler does a redirect, so both you and the fabric api can't do it at the same time.
If you want your own version, you would need to remove the fabric-api version.

The symptoms of what you describe, make it sound like the data is not being sent to the client when you right click.
But it is hard to say without seeing the code.

Are you calling sync() when you change the block entity's state on the server?
https://github.com/FabricMC/fabric/blob/1.17/fabric-networking-blockentity-v0/src/main/java/net/fabricmc/fabric/api/block/entity/BlockEntityClientSerializable.java

Try adding some debug messages to your "toClientNBT()" and "fromClientTag()" to see if they are being invoked and they contain the data you expect.

[theAfish]

I used the sync() in the onUse() method of my blockentity's block directly after changing the item saved in it. Is that the right way to use it?

Actually I used System.out.println() to debug. However, neither "toClientNBT()" nor "fromClientTag()" seems to be invoked.

So I think there must be something wrong with my code?

[theAfish]

I found the problem! I was wrongly override the toUpdatePacket() method. Now it works! Thank you very much!