Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Replace Hoedown (unmaintained, but works) #69

Open
FSX opened this issue Feb 27, 2019 · 8 comments
Open

Replace Hoedown (unmaintained, but works) #69

FSX opened this issue Feb 27, 2019 · 8 comments

Comments

@FSX
Copy link
Owner

FSX commented Feb 27, 2019

Hoedown hasn't seen any commits since 2015. AFAIK it's good enough, but I'd like a maintained library as the back-end for Misaka.

There's:

For the time being I don't have time for this, but I'll keep it in mind.

@FSX FSX added the Maybe label Feb 27, 2019
@kingclowndean
Copy link

kingclowndean commented Feb 27, 2019 via email

@FSX FSX removed the Maybe label Jul 7, 2019
@FSX
Copy link
Owner Author

FSX commented Jul 7, 2019

Working on this now.

@FSX FSX added the In Progress label Jul 7, 2019
@FSX
Copy link
Owner Author

FSX commented Jul 7, 2019

Chose MD4C.

@FSX
Copy link
Owner Author

FSX commented Jul 10, 2019

Track development here: https://github.com/FSX/misaka/tree/md4c-backend

@DanielG
Copy link

DanielG commented Nov 7, 2019

Is changing the backend C library not likely to change misaka's behaviour in subtle ways and just potentially introduce new bugs? i.e. is this really a good idea?

Let me explain -- I'm currently working on packaging misaka 2.* for Debian with hoedown properly seperated out as another package rather than embedded in misaka. As part of my review of hoedown I also noticed that the project is essentially dead. In light of this I also had some security concerns but I've since done some fuzzing with AFL and I have to admit I'm impressed.

After over 1.5 billion different test cases the fuzzer still hasn't found a single crash so I'm wondering if maybe this is just an instance of a project being "complete" and not really in need of maintanance :)

Let me know what you think.

@FSX
Copy link
Owner Author

FSX commented Nov 7, 2019 via email

@DanielG
Copy link

DanielG commented Nov 7, 2019

I don't want to maintain hoedown by myself either really :), but just looking at how many other libraries are using it I have a feeling efforts could be pooled to keep it maintained. Personally I think the risk of switching the backend is greater than that of just continuing to maintain hoedown.

I can totally relate to the uneasy feeling of using an unmaintained library, but are there any issues that really need fixing at the moment? Also have you talked to any other users of the library about this? Probably should get some feedback on how the people using the library feel about this.

@FSX
Copy link
Owner Author

FSX commented Nov 7, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants