extcommunity-list expanded x delete matches against all extended community values making it impossible to delete only a single extcommunity by regex

[rudis]

Description

I'm trying to delete one type of extended community with any value (e.g. all "RT:x:y", no matter x and y) but not extended communities with other types.

The following config removes all extended community entries, even non RT types.

bgp extcommunity-list expanded exp seq 5 permit RT:
route-map test permit 10
 set extended-comm-list exp delete
exit

Removing a single RT value works (only RT:65002:9001 is removed):

bgp extcommunity-list standard std seq 10 permit rt 65002:9001
route-map test permit 10
 set extended-comm-list std delete
exit

The problem seems to be that ecommunity_list_match_delete passes ecom to ecommunity_regexp_match and not local_ecom. So the full string of the ecommunity is compared in each iteration. Fixing this should be as simple as passing local_ecom, but I didn't test it.

From a quick look it the same issue affects community_list_match_delete and lcommunity_list_match_delete as well. Or is this expected behavior?

Version

10.1.1, also present in current git

How to reproduce

See above

Expected behavior

extcommunity-list expanded matches against a single ecommunity value.

Actual behavior

extcommunity-list expanded matches against the whole ecommunity value.

Additional context

No response

Checklist

• I have searched the open issues for this bug.
• I have not included sensitive information in this report.

[ton31337]

Well, "RT:" is too simple to be evaluated strictly, so it matches everything that has RT:*. (expected). The idea of how it works is, that we convert all the extended communities into a string (e.g. RT:1.1.1.1:1 RT 2.2.2.2:2), then apply RT: which matches a string.

If you specify something like bgp extcommunity-list expanded r1-rt seq 5 permit RT:1.1.1.1:1$ it won't match because the end ($) is with 2.2.2.2:2.