Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code not explicit where the login redirect url is #28

Open
m4v15 opened this issue Apr 13, 2017 · 0 comments
Open

Code not explicit where the login redirect url is #28

m4v15 opened this issue Apr 13, 2017 · 0 comments
Assignees
Labels

Comments

@m4v15
Copy link
Member

m4v15 commented Apr 13, 2017

  handler: (request, reply) => {
    const params = {
      client_id: process.env.CLIENT_ID
    };
    reply.redirect(`https://github.com/login/oauth/authorize?${qs.stringify(params)}`);
  }

I know you don't need to say what the redirect url is as when you registered your app you gave github a redirect url, but as a code reviewer I don't know where this will redirect me.

@macintoshhelper macintoshhelper self-assigned this Apr 13, 2017
Suuuuha added a commit that referenced this issue Apr 13, 2017
Issue #28 - Add redirect_uri to routes/login.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants