Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

admin deployment missing nodeselector, affinity and tolerations #55

Open
drryu opened this issue Jan 6, 2020 · 0 comments · May be fixed by #56
Open

admin deployment missing nodeselector, affinity and tolerations #55

drryu opened this issue Jan 6, 2020 · 0 comments · May be fixed by #56

Comments

@drryu
Copy link

drryu commented Jan 6, 2020

Version of Helm and Kubernetes:
Helm
version.BuildInfo{Version:"v3.0.1", GitCommit:"7c22ef9ce89e0ebeb7125ba2ebf7d421f3e82ffa", GitTreeState:"clean", GoVersion:"go1.13.4"}

Kubernetes -
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.8", GitCommit:"211047e9a1922595eaa3a1127ed365e9299a6c23", GitTreeState:"clean", BuildDate:"2019-10-15T12:11:03Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:07:57Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
0.2.5

What happened:
admin deployment is missing support for nodeselector, tolerations and affinity, hence unable to schedule pod on a tainted node.

What you expected to happen:
I should be able to schedule the admin deployment to a node that has taints defined on it

How to reproduce it (as minimally and precisely as possible):
If all nodes in the cluster have taints defined on them, the helm chart deployment is unsuccessful and there is no way to tolerate a taint for the admin deployment. The toleration is only applied to the statefulset, hence the stateful set is the only one that gets scheduled.

Anything else we need to know:
I have added support for nodeselector, affinity and tolerations for the admin deployment. Will create a pull request. Please review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant