Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

Custersize documentation default does not match actual value #36

Open
GoatCodeNL opened this issue Jun 7, 2019 · 2 comments · May be fixed by #37
Open

Custersize documentation default does not match actual value #36

GoatCodeNL opened this issue Jun 7, 2019 · 2 comments · May be fixed by #37

Comments

@GoatCodeNL
Copy link
Contributor

Is this a request for help?:
No

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes:

Client: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}

Which chart:
eventstore/eventstore

What happened:
Deployed a new eventstore to kubernetes. Documentation states that clustersize is 3, yet it actually is 1.

What you expected to happen:
Cluster to be size 3

How to reproduce it (as minimally and precisely as possible):
helm install -n eventstore eventstore/eventstore

Anything else we need to know:
This was changed in #30. I think it was accidentally committed as the PR does not give any reason to decrease default cluster size.
@GoatCodeNL
Copy link
Contributor Author

GoatCodeNL commented Jun 7, 2019 •
edited
Loading

Fixed in: #37

@GoatCodeNL GoatCodeNL linked a pull request Jun 7, 2019 that will close this issue
Open
3 tasks
@ameier38
Copy link
Contributor

ameier38 commented Jun 13, 2019 •
edited
Loading

In the description of #30

So that port forwarding works out of box I think it is better to set the default clusterSize=1.

My mistake to not update the docs. Only reason it was changed to 1 was so that the port-forwarding worked out of the box to help with debugging. Otherwise the only I could figure out how to debug locally was using a tool like telepresence.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed default cluster size back to 3 saa-nl/EventStore.Charts
2 participants
@ameier38 @GoatCodeNL