Supporting GET queries with disable_stats=true and enable_queue_totals=true #316
Closed
inikulshin
started this conversation in
General
Replies: 1 comment
-
Redesigned in #319 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
https://rawcdn.githack.com/rabbitmq/rabbitmq-server/v3.12.12/deps/rabbitmq_management/priv/www/api/index.html
Recently I added
GetQueuesWithoutStatsAsync
method, and also made record hierarchyrecord Queue
:QueueWithoutStats
:QueueName
.However, this method uses
disable_stats=true&enable_queue_totals=true
query. And fordisable_stats=true
query separate method and separaterecord
is required. And there is no way to insertrecord QueueWithoutStatsAndTotals
to the record hierarchy as there is no multiple inheritance. That means, my design is bad.I think better solution is to have only
record Queue
:QueueName
, mark all the properties ofQueue
that can be disabled by query parameters asnullable
(maybe even integers), and add optional flags toGetQueuesAsync
method:Task<IReadOnlyList<Queue>> GetQueuesAsync(bool disableStats = false, bool enableQueueTotals = false, CancellationToken cancellationToken = default);
Similarly to
Exchange
:Task<IReadOnlyList<Exchange>> GetExchangesAsync(bool disableStats = false, CancellationToken cancellationToken = default);
And so on.
@zidad @Pliner @micdenny FYI.
Beta Was this translation helpful? Give feedback.
All reactions