More reliable datasets to recipe conversion #2472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2472 +/- ##
==========================================
- Coverage 94.62% 94.61% -0.01%
==========================================
Files 247 247
Lines 14057 14060 +3
==========================================
+ Hits 13301 13303 +2
- Misses 756 757 +1 ☔ View full report in Codecov by Sentry. |
|
I think I know now what's going on in #2466. In summary, datasets from two different rootpaths might have different facets in the input directory DRS which may lead to different types of the facet values. Unfortunately, this PR does not fix that problem; I am still getting the same errors. |
valeriupredoi
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
_to_frozenaccept more types of input data to avoid a crash.Closes #2466
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: